Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LPBatcher issue - lines longer than the buffer size lead to emitting 0 size packets and unemptied buffer #127

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

karel-rehor
Copy link
Contributor

Proposed Changes

Motivated by EAR 5762

In LPBatcher.emitBytes()

  • Check whether the first line exceeds the buffer size.
  • If it does, just emit the first line and adjust the buffer accordingly
  • If not, proceed with emitting the packet and correct the buffer as before

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@karel-rehor karel-rehor merged commit 53e02a2 into main Jan 15, 2025
7 checks passed
@karel-rehor karel-rehor deleted the fix/ear5762 branch January 15, 2025 16:45
@bednar bednar added this to the 2.1.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants